Open Source Integrated Library System

Evergreen on IRC

#evergreen Logs for Thursday, October 27th, 2011

< Wednesday, October 26th, 2011Raw Log FileFriday, October 28th, 2011 >
#TimeNickMessage
#00:10:05sndwrx has joined #evergreen
#06:01:03lisah___ has joined #evergreen
#06:07:36lisah___ has quit IRC
#06:15:40wlayton has joined #evergreen
#06:54:21wlayton has quit IRC
#08:01:33csharpokay - quick "how we use git in Evergreen" question...
#08:02:16csharpI would like to start tracking PINES changes from a downloaded Evergreen repo - should I create a branch? or a new project? or what?
#08:03:00csharpideally we would push our changes to our own branch/project/section of git.evergreen-ils.org
#08:14:34csharpokay - looking at the project list on the git start page, we would probably want something like evergreen/pines.git
#08:16:14tsberecsharp: To get your changes from the downloaded repo you probably want to patchify them
#08:16:40tsbereIf they aren't patchified already
#08:17:17csharpthey aren't yet
#08:18:05tsbereIf they are literally just edited files in a dumped tarball then I would recommend checking out the same version from git (by tag), overwriting everything in the repo, then git adding any files you *created* followed by a git commit -a to get all the changes. This will create one giant commit of "Pines Changes" as a starting point, at least.
#08:18:05csharpmy short term goal is to take rel_2_1_0 and patch it with our changes and push it somewhere
#08:18:31csharptsbere: okay - that's what I'm after
#08:19:00tsbereIf you have discrete changes you know how to apply manually (or are the only changes to a file) you can do it in chunks instead
#08:19:15tsbereWhich I find to be easier. I keep multiple branches for MVLC customizations, in fact.
#08:19:43csharpwell, I have a good amount of organization to do, but I wanted to start with our tweaks to the upgrade scripts
#08:19:48tsbereAt least one of those branches is maintained by Dyrcona, actually, and has to be kept in a "private" repo. It contains all of our SIP config (with passwords)
#08:19:57csharpI see
#08:21:17tsbereIf you want to keep things you aren't concerned with, like skin tweaks and such, that don't have passwords or other sensitive things included on git.evergreen-ils.org in a public area then you will need to do two things
#08:21:33tsbereOne is get us a pubkey, because I don't see you in the list yet
#08:21:46tsbereThe other is ask for a repo area
#08:22:02csharptsbere: that's what I was after ;-)
#08:22:13tsbereEach person you want to be able to access the repo for writing will need a pubkey on the server, if they don't have one already.
#08:22:41tsbereAnd if you use more than one pubkey, say from different machines, you can send them all in
#08:22:50csharpgreat
#08:23:23csharptsbere: would one big text file with them (one per line) work?
#08:24:01tsbereIf they are in openssh format (for inclusion in authorized_keys) then yes. I suppose you could just hand me an authorized keys file, actually. I will need to split it into chunks, but that isn't hard.
#08:24:26csharpyeah - that's what they would be
#08:24:33csharpokay - works for me
#08:24:38tsberegmcharlt: If you are around, I will take care of csharp's stuff here ;)
#08:24:45csharptsbere: thanks (as always ;-))
#08:24:54tsberecsharp: Easiest way to get it in is probably to email it to the gitadmins address
#08:25:37csharp goes off to gather keys
#08:27:19tsbereDo you want the repo to only mirror master automatically, or would you like it if the repo itself duped rel_2_1 from the official repo as well?
#08:27:44csharpto be honest - I don't know ;-)
#08:28:19csharpmanaging a single release is my short term goal, but I'd like room to expand ;-)
#08:29:05csharpif the repo mirrors master, does that include all backports, etc. to each of the branches, or just changes to master?
#08:29:42tsbereJust changes to master
#08:29:50csharpmkay
#08:29:57tsbereTake note you can always have other repos as remotes anyway
#08:30:01mrpeters-islcsharp: http://git.evergreen.lib.in.us/git/?p=Evergreen.INCustom/Evergreen/.git;a=summary
#08:30:04tsbere has a small pile of remotes, in fact
#08:30:48csharpmrpeters-isl: yes - that's the kind of thing I'm after
#08:30:53mrpeters-isltsbere taught me cherry-picking all of our customizations into the heads for rel_2_0 and that made it super easy to apply our changes to rel_2_1, master, and beyond
#08:31:07csharp is using git day to day, but has not gotten in deep
#08:31:20tsberemrpeters-isl: Did you want that to get auto-updating master fun?
#08:31:31csharp has a bunch of tutorials open in tabs in his browser right now ;-)
#08:31:36mrpeters-isli haven't yet
#08:31:44mrpeters-islcsharp: how are your customizations tracked now?
#08:32:01csharpmrpeters-isl: patches are dumped into a github repo
#08:32:10mrpeters-islok, thats good
#08:32:14tsberemrpeters-isl: Specifically, do you want that added to the list of places that get a copy of anything that changes in master? We have a list. :P
#08:32:15csharppatches/files/readmes, etc.
#08:32:22csharpnot very well organized
#08:32:28mrpeters-isli think you could add your github as a remote and cherry pick from it
#08:32:34csharpah
#08:32:49mrpeters-islso, each commit has a hash
#08:33:09mrpeters-islgit-cherry-pick somehash
#08:33:25mrpeters-islsometimes they merge right in, sometimes you have to do some manual editing to resolve differences
#08:33:38mrpeters-isltsbere: i'd be down for that
#08:33:43csharpcool
#08:34:10_bott_ has quit IRC
#08:34:12tsberecsharp: IF you use git cherry-pick -n it will grab the changes, but not commit them. Useful if you want to combine several changes, or if you are literally grabbing patch files to apply (and then delete)
#08:34:18AaronZ-PLS has joined #evergreen
#08:34:36mrpeters-islcsharp: http://www.vogella.de/articles/Git/article.html#github
#08:35:14_bott_ has joined #evergreen
#08:35:20mrpeters-islso i'd start a repo called Evergreen.GACustom or something
#08:35:21tsbere dislikes github for reasons of "you can't use these tools with github" notes that they have, despite being able to use said tools. Easily.
#08:35:32mrpeters-islthen git clone git://git.evergreen-ils.org/Evergreen.git into it
#08:39:57mrpeters-islfrom there, you'd then start with a branch based on whatever release you're upgrading to
#08:40:33mrpeters-islso, say git checkout --force -b rel_2_0_4 refs/heads/rel_2_0
#08:40:56mrpeters-island then start applying your patches
#08:43:02plux_ has joined #evergreen
#08:43:42mrpeters-islone thing is for sure, csharp -- it's WELL worth the effort to do what you're planning
#08:52:33csharpmrpeters-isl: yeah - I've been planning to do it for a long time - our current project requires it ;-)
#08:53:09csharp got tired of digging around in his github repo for this or that patch
#08:55:01mrpeters-islyou could also get all of your patches from git hub and "git-apply foo.patch" to whatever branch
#08:55:21jenny has joined #evergreen
#08:55:46mrpeters-island then when it comes time to apply them all to say, rel_2_1, you can just git-cherry-pick across your local branches
#08:56:10csharpnice
#08:59:34tsberemrpeters-isl loves git since I helped him convert to it ;)
#08:59:45mrpeters-islyep...you saved me
#09:07:07gmcharltcsharp: keys received (it's gitadmin@)
#09:07:49tsbereDid he send them to the wrong location?
#09:07:58csharpgmcharlt: got it
#09:08:00tsbere has a starter set of config changes ready to go
#09:08:12gmcharlttsbere: check your email
#09:09:43tsbereHmmm. Seems to have been greylisted. Did the server handling the git admin account change IPs?
#09:09:52tsbereOr was it sent more directly and thus bypassed said server?
#09:10:05gmcharltcsharp had sent it to us directly
#09:10:25tsbereahhh. That would explain why it was greylisted, then.
#09:12:01csharpgmcharlt: tsbere: in case it makes a difference in what you're setting up, we would also probably be committing our packaging materials and other automating scripts to projects within that same space if possible
#09:12:48tsbereThe way I am setting it up the entire repo aside from "master" will be yours to create stuff in anyway. If you want a second repo for some of your other stuff, though, I can add that in.
#09:13:02gmcharltcsharp: that probably calls for an additional contrib/GPLS.git repo, then
#09:13:28gmcharltunless all of that other stuff is expressible as a topic branch against the Evergreen source tree
#09:14:10gmcharltor contrib/PINES.git, however you want it named
#09:14:20csharpgmcharlt: it's not - I think a contrib branch would be more appropriate
#09:14:32csharpthat name works for me
#09:14:45gmcharltwhich one?
#09:14:49csharpsorry :-0
#09:14:59csharplet's use PINES
#09:15:06gmcharlt:)
#09:15:27tsbere was already using "pines" anyway in the config file
#09:19:07tsberegmcharlt: I could throw the config changes in and let you deal with the keys. You might like my keyconvert.sh file, though, to split a file full of one person's keys into individual files.
#09:19:32gmcharlttsbere: I'll handle the keys, then
#09:19:46tsbere hates waiting for the greylister
#09:20:33kmlussier has joined #evergreen
#09:22:48gmcharltcsharp: I see that one of the keys is a personal one - should the rest be named generic pines keys?
#09:22:59tsberegmcharlt: I pushed the config. And my keyconvert, if you want it.
#09:23:09csharpgmcharlt: sure
#09:26:12tsbereAnd automatic updating of the "master" branch is active :D
#09:27:43gmcharltcsharp: ok, you should be all set up
#09:28:43gmcharltgit urls are git@git.evergreen-ils.org:contrib/pines.git and git@git.evergreen-ils.org:evergreen/pines.git
#09:28:45csharpgmcharlt++
#09:28:52csharptsbere++
#09:28:53csharpthanks!
#09:33:16csharpso I've cloned the repo... how would I bring in tags/rel_2_1_0 from Evergreen.git?
#09:33:47mrpeters-isl git checkout --force -b rel_2_1_0 tags/rel_2_1_0
#09:34:03mrpeters-islat least...i think thtas the right path...going from memory
#09:34:07tsberegit add egils git://git.evergreen-ils.org/Evergreen; git fetch egils; git checkout -b rel_2_1_0 egils/tags/rel_2_1_0
#09:34:23tsbereThen git push origin rel_2_1_0
#09:34:27tsbere(or make changes then push)
#09:34:39tsbereOh, git remote add, not git add
#09:34:40tsbere<
#09:34:42tsbere*<_<
#09:34:48tsbere got ahead of himself when typing
#09:36:40csharp is giddy with excitement
#09:36:51csharpthis'll be awesome
#09:37:16csharpforgot
#09:37:20csharpmrpeters-isl++
#09:38:36mrpeters-islhas anyone considered updating eg.conf (Apache2) to prevent against the BEAST attacks? I patched ours, but thought maybe it'd be worth sharing here. Something for the Security team, perhaps?
#09:40:25gmcharltwell, it's kinda out now, isn't it
#09:40:32gmcharltsec, I'll give you a patch to test and sign off on
#09:40:45mrpeters-isli've actually got it in a branch
#09:40:47mrpeters-isljust need to push it
#09:40:48sfortin has joined #evergreen
#09:40:55eeevilmrpeters-isl: if you have attack detail, please start by opening a security bug
#09:41:08eeevilin the future, obv
#09:41:24mrpeters-islok, apologies. didn't realise i could.
#09:41:29csharpokay - now to the issue that opened the git can of worms for me...
#09:41:35tsbereI thought this was a generic apache issue, more than an evergreen issue.
#09:41:49gmcharlttsbere: indeed
#09:41:55csharpin the 2.0-2.1 upgrade script, it fails on CREATE OR REPLACE FUNCTION actor.usr_purge_data
#09:42:23tsbere doesn't see why we would need to "hide" security issues that are public on the upstream of the third party stuff we use
#09:42:40csharp digs for the error message
#09:43:21eeeviltsbere: it's not about hiding them, per se, but allowing a coordinated message to be crafted that's specific to normal EG setups
#09:43:46eeeviland it confers some priority to the problem
#09:43:53eeevilIMO, at least
#09:44:46mrpeters-isli just happened to catch it yesterday when updating SSL certs
#09:45:03mrpeters-islthought i'd share but yeah, my bad should have done it more privately
#09:48:40csharppsql:2.0-2.1-upgrade-db.sql:636: ERROR: cannot change name of input parameter "dest_usr"
#09:48:55csharpthat's what I've got that I'm hanging on
#09:49:21mrpeters-islcsharp: https://bugs.launchpad.net/evergreen/+bug/725809
#09:49:37csharpheh
#09:49:53csharp really should read the massive amount of bug notification emails he gets
#09:50:06mrpeters-islDr. Google wins again!
#09:50:13csharpmrpeters-isl: thanks
#09:50:38mrpeters-isli always just search open-ils and my error and I can usually find a log from here, or a bug ticket
#09:50:50csharphmm - seems that like that would've been fixed in rel_2_1_0, though
#09:51:04mrpeters-islyeah, but maybe the same concept applies for fixing it this time too?
#09:51:15csharpno - I'm sure that's right
#09:51:22csharpit was what I was going to try anyway ;-)
#10:04:33Dyrcona has joined #evergreen
#10:04:59leed has joined #evergreen
#10:05:07Dyrcona thinks it might be useful if staff could manage their own or shared book bags from the client.
#10:06:01eeevilDyrcona: they can't?
#10:06:17Dyrconaeeevil: If they can, then I don't know how.
#10:06:29eeevilin the embedded opac?
#10:06:44Dyrconaeeevil: doh. why didn't I try that?
#10:07:23Dyrconaeeevil++
#10:07:34Dyrconafor pointing out the obvious. :p
#10:07:38eeevilI do what I can
#10:07:44tsbereLooks like the uncoded failures fix made SIP happier for us :D
#10:07:55Dyrconatsbere++
#10:08:07DyrconaDoes it fix the problem that you mentioned to me yesterday?
#10:08:13tsbereStill some annoying GIGO errors from SIPServer itself.
#10:08:46tsbereDyrcona: looks like it. I saw two apparently complete success entries in the logs.
#10:09:01tsbereWithin minutes of restarting SIP with the new code
#10:10:05DyrconaGood to know.
#10:10:29DyrconaI may actually use my home_ou today.
#10:10:37DyrconaThey have a book in reshelving that I want.
#10:13:17csharpsorry for the git newbie questions, but I would like to "branch a branch", meaning that I would like to create multiple branches of rel_2_1_0 (one for general customizations, one for skin development, etc.)
#10:13:43Dyrconagit checkout -b new_branch old_branch
#10:13:51csharpDyrcona: ah - that's it
#10:13:52csharpthanks
#10:13:53tsberecsharp: git checkout -b newbranch egils/tags/rel_2_1_0 with whatever newbranch names you want
#10:14:01tsberecsharp: Then later you can git merge them all together ;)
#10:14:03csharpexcellent
#10:17:04Dyrconagah! "Authentication is required to print....."
#10:17:20Dyrcona mumbles something about cupsd and Oneiric....
#10:20:55Dyrcona goes looking for a #samba channel.
#10:25:39leed has quit IRC
#10:25:51leed has joined #evergreen
#10:28:39sal_ has joined #evergreen
#10:28:48tsbereHmmm
#10:29:31tsbereWe have 11703 circs that have 0.00 owed and have a checkin time, but have no xact_finish time. Is this normal?
#10:29:45mrpeters-isltsbere: i think we have the same situation a lot
#10:29:46Dyrcona gets nervous whenever tsbere goes "hmm."
#10:35:14tsberemrpeters-isl: How do you deal with it, normally?
#10:35:56mcarlson has quit IRC
#10:35:56b_bonner has quit IRC
#10:35:56mrpeters-islto be honest, it usually ends up being a deal where someone spots it (say, a Claims Returned still showing up after all billings paid) and reports it to our helpdesk
#10:36:07tsbereand what do they do to fix it?
#10:36:29mrpeters-islwe just set xact_finish to a date that makes sense, such as the date of the final payment
#10:36:45tsbereThat was what I was thinking about doing.
#10:37:37b_bonner has joined #evergreen
#10:37:44mrpeters-islwhat query did you use to identify them?
#10:38:02tsbereselect * from money.materialized_billable_xact_summary mmbxs JOIN action.circulation USING (id) WHERE checkin_time IS NOT NULL AND balance_owed = 0.00 AND mmbxs.xact_finish IS NULL
#10:38:07mcarlson has joined #evergreen
#10:38:44mrpeters-islk let me see how bad it is for us
#10:39:21mrpeters-isli'm thinking https://bugs.launchpad.net/evergreen/+bug/758982 is maybe one of the causes as well
#10:40:01mrpeters-islheh 62,070 for us
#10:40:25tsbereI have a query to "fix" them ready to go. Want that?
#10:40:44mrpeters-islyeah i'd be curious...but i need to ponder if i want to run it or not haha
#10:41:04tsbereAdd "UPDATE action.circulation SET xact_finish = COALESCE(x.last_billing_ts, x.checkin_time) FROM (" before that query and ")x" after it
#10:41:28tsbereNo, wait, I need a join on the id
#10:41:36tsbere opens the file again
#10:41:55tsbereOh, I have a where clause on the next line.
#10:42:46tsbereWHERE circ.id = x.id ... I think I need to alias action.circulation as "circ" too or this is gonna error out
#10:44:16lisah___ has joined #evergreen
#10:46:01mrpeters-isli guess for me to be comfortable, we need to figure out if there is ever a valid reason to have xact_finish like this
#10:53:26Dyrcona wonders if it would be an Evergreen staff client bug or a XulRunner bug that the client cannot print to servers that require authentication.
#10:54:14Dyrcona doesn't get the driver's authentication dialog on Ubuntu Oneiric from the staff client, but does get it in Chromium, etc.
#10:55:06mrpeters-islDyrcona: wouldn't printing from firefox work similarly? does that let you print on that server?
#10:57:07Dyrcona doesn't use firefox, but its likely installed will check after switching to a postscript driver....PCL 3 gives me some garbage.
#10:59:19mrpeters-isli think it is by default in ubuntu
#11:01:03Dyrconamrpeters-isl: I switched to Chromium to try it out and I liked it enough to make it my default browser.
#11:01:21DyrconaFirefox prompts for the password, but the staff client doesn't.
#11:01:42mrpeters-islnewer xulrunner in FF probably
#11:02:00DyrconaI have also found Oneiric to be rather buggy in many ways that Natty wasn't, just in case anyone is thinking of upgrading.
#11:03:23DyrconaYes, most likely. I am using the 1.9.2.22 XulRunner that gets bundled with the linux client builds.
#11:04:21DyrconaFirefox is version 7.0.1, so definitely a newer XUL runtime there.
#11:05:15DyrconaAh well, just means I can't print from the client on my laptop for the time being. Carry on with your more important discussions. :)
#11:07:02csharpokay when running the PG 9.1 re-req scripts, hstore was not installed for some reason...
#11:07:58csharpI see three files in /usr/share/postgresql/9.1/extenstion: hstore--1.0.sql, hstore--unpackaged--1.0.sql and hstore.control - does anyone know which one I want?
#11:08:11mrpeters-isllet me look at my notes csharp
#11:08:59tsberecsharp: Just use the create extension command?
#11:09:29csharptsbere: ah
#11:09:50mrpeters-islyeah i think i just did CREATE EXTENSION hstore;
#11:10:00csharpthat would make sense with what I'm seeing - looks like more of a packaging system than before
#11:10:21mrpeters-islcsharp: http://developer.postgresql.org/pgdocs/postgres/sql-createextension.html
#11:11:07csharpgood
#11:11:24csharpthat's a much better way to do it
#11:11:27granitize has joined #evergreen
#11:25:39tspindler has joined #evergreen
#11:44:52yboston has joined #evergreen
#11:46:05granitize has left #evergreen
#11:54:06granitize has joined #evergreen
#12:22:24plux_ has quit IRC
#12:29:04granitize has left #evergreen
#12:30:22plux_ has joined #evergreen
#12:31:29AaronZ-PLS has quit IRC
#12:36:52AaronZ-PLS has joined #evergreen
#12:55:52sal_ has quit IRC
#13:13:09csharpokay - another git/installation question... we have several files that we add (/openils/conf/lib_ips.txt, /openils/var/data/zips.txt, for instance)... If I place them in the source tree appropriately, will they be installed correctly, or do I have to tell a makefile or something about them?
#13:14:11tsbereI think if you place them properly they will get installed. Although I also think we just edit the .example files anyway.
#13:14:26tsbereBut I dunno about data/ there
#13:14:34csharpok
#13:24:52sal_ has joined #evergreen
#13:49:02sal_ has quit IRC
#13:51:22sal_ has joined #evergreen
#13:59:01lisah___ has quit IRC
#14:13:00jeffdavis has quit IRC
#14:31:45lisah___ has joined #evergreen
#14:45:12AaronZ-PLS has quit IRC
#14:52:55jeffdavis has joined #evergreen
#14:53:51jenny has left #evergreen
#15:17:58sal_ has quit IRC
#15:45:30granitize has joined #evergreen
#15:45:54granitize has left #evergreen
#15:49:39tspindler has quit IRC
#15:53:22youdonotexist has joined #evergreen
#16:04:59plux_ has quit IRC
#16:15:17sfortin has quit IRC
#16:46:43kmlussier has quit IRC
#16:58:41sal_ has joined #evergreen
#17:32:31leed has quit IRC
#17:42:36yboston has quit IRC
#18:05:23leed has joined #evergreen
#18:07:43Dyrcona has quit IRC
#18:21:43leed has quit IRC
#18:27:18csharp is bitten by the bug agJohn reported the other day: https://bugs.launchpad.net/evergreen/+bug/881774
#18:27:35csharpERROR: function array_remove_item_by_value(text[], unknown) does not exist
#18:28:07csharplooks like it may need to be evergreen.array_remove_item_by_value(), but I don't know
#18:30:24lisah___ has quit IRC
#18:39:36youdonotexist has quit IRC
#18:48:29tsberecsharp: Perhaps you should do a ALTER DATABASE <dbname> SET search_path=evergreen, public, pg_catalog;
#18:55:24AaronZ-PLS has joined #evergreen
#18:57:30AaronZ-PLS has quit IRC
#19:00:10jeffdavis has quit IRC
#19:01:18jeffdavis has joined #evergreen
#19:23:33csharptsbere: thanks - will try
#19:25:36csharphmmm - more may be off than just that: NOTICE: schema "evergreen" does not exist
#19:25:48tsbereHmmm. That is a good point on problem front.
#19:25:49tsbereGimme a min
#19:27:15tsbereHmmm. The upgrade script includes "SELECT evergreen.change_db_setting('search_path', ARRAY['evergreen','public','pg_catalog']);" which should be triggering that anway.
#19:27:29tsbere*anyway
#19:27:45csharphuh
#19:27:50tsbereUnless that isn't working?
#19:28:07tsbereAre you running the script with superuser rights?
#19:28:12csharpyes
#19:28:17tsberehmm
#19:29:27csharp reviews the postgres log
#19:32:15csharpnope - no mention of evergreen in the log
#19:32:25tsbereWhich may just mean it worked
#19:32:34csharpit's the first frickin' line in the script CREATE SCHEMA evergreen;
#19:34:16csharppsql:2.0-2.1-upgrade-db.sql:5: ERROR: schema "evergreen" already exists
#19:34:25csharpso maybe I was in the wrong db
#19:34:29tsbereok
#19:34:31csharppostgres maybe?
#19:34:53tsbereWhat is your current search path?
#19:35:42tsbereI think you can get it via "SHOW search_path;" when in your EG database
#19:36:15csharpyeah - it works now
#19:36:43csharpI was in postgres's db
#19:36:49csharpso that was the issue
#19:37:02csharp cranks the script back up
#19:39:40wlayton has joined #evergreen
#20:23:15sndwrx has quit IRC
#20:27:09sndwrx has joined #evergreen
#21:02:26wlayton has quit IRC
< Wednesday, October 26th, 2011Raw Log FileFriday, October 28th, 2011 >