Open Source Integrated Library System

Evergreen on IRC

#evergreen Logs for Thursday, September 22nd, 2011

< Wednesday, September 21st, 2011Raw Log FileFriday, September 23rd, 2011 >
#TimeNickMessage
#00:02:34dbs finds it cute that tsbere's "how to use git" messages in LP are about 5x as long as the actual description of the bug being fixed :)
#00:11:49matt_carlson has joined #evergreen
#00:16:43matt_carlson has quit IRC
#00:17:52matt_carlson has joined #evergreen
#00:19:39edoceo has quit IRC
#01:11:21dbsgrabbing 0627
#01:26:00dbs has quit IRC
#01:43:25matt_carlson has quit IRC
#02:22:36tsbere has quit IRC
#02:22:50tsbere has joined #evergreen
#05:55:46artunit has quit IRC
#07:56:07collum has joined #evergreen
#08:26:55jeffdbs++ #burning the midnight oil
#08:31:08berickdbs++
#08:34:08artunit has joined #evergreen
#08:35:40Dyrcona has joined #evergreen
#08:52:18tspindler has joined #evergreen
#09:02:35csharp is able to do the 'make win-client' step by changing 'releases.mozilla.org' to 'download02.mozilla.org' in the Makefile
#09:02:39csharpFYI
#09:03:24tsbereI thought phasefx pushed a change to the version number already to make either work
#09:03:53csharptsbere: it was a 404 error on "releases.mozilla.org" that stopped me
#09:04:04csharp is using rel_2_1 btw
#09:04:09tsbereYou must not have pulled the commit from phasefx yesterday?
#09:04:18csharptsbere: ah - guess not ;-)
#09:04:40tsbereStill, something to think about. Although that is a "low bandwidth" server.
#09:04:48csharphmm
#09:05:15csharpI'm still for starting an 'archive.evergreen-ils.org' server that hosts it just for us
#09:05:31Dyrcona hates telling other people how to do their jobs.
#09:06:24tsberecsharp: phasefx thinks we should just bundle the xulrunner files with the releases from 2.1 on. If they are already there the makefile doesn't look to download them.
#09:06:38Dyrconatsbere: he made that commit after csharp made the report.
#09:06:40csharptsbere: even better
#09:07:32dbwells_ is now known as dbwells
#09:12:15csharphmm - an alert window at startup: "messageCatalog: No text from chrome://open_ils_staff_client/locale/offline.properties"
#09:12:33csharp"Error loading properties in messagecatalog in bindings.xml: messageCatalog: No text from chrome://open_ils_staff_client/locale/offline.properties"
#09:13:08mrpeters-isl has joined #evergreen
#09:13:30tsberecsharp: Just git pull.
#09:13:37tsbereYou obviously need the latest fixes ;)
#09:13:41csharptsbere: okey doke ;-)
#09:15:01csharpokay - this may be a git n00b question, but I need to "upgrade" after pulling, right?
#09:15:13tsbere?
#09:15:23tsberegit pull does a fetch and updates your local checkout
#09:15:50csharpwell, the files I pulled in aren't installed, right - so do I need to go through an upgrade process?
#09:16:03Dyrconacsharp: yes.
#09:16:09tsbereWell, depending on what came down ;)
#09:16:54Dyrconacsharp: sometimes when changes are minor, I'll copy files by hand on my development server, like if I testing changes to a development branch, but the upgrade is best when pulling in wholesale changes from elsewhere.
#09:17:14csharpDyrcona: okay - that makes sense
#09:20:12atz_ has joined #evergreen
#09:23:21atz__ has quit IRC
#09:26:57tsbereAnyone have thoughts on http://git.mvlcstaff.org/?p=tsbere/ILS.git;a=shortlog;h=refs/heads/fix_item_status_strict_barcode ?
#09:35:17dbs has joined #evergreen
#09:35:17dbs has joined #evergreen
#09:36:12sal_ has joined #evergreen
#09:41:50kmlussier has joined #evergreen
#09:42:57csharpokay, I just started it up but - already...
#09:43:00csharp2.1++
#09:43:22csharpthe toolbar functions will be extremely popular here
#09:45:06dbstsbere: what does "Characters like . are valid for numbers" mean? Maybe more description in the commit, and maybe comment the line in the code.
#09:45:58tsberedbs: Literally ., like "16.00" is a number, as is "1600"
#09:46:14tsbereSo "16.00" == Number("16.00") works.
#09:46:15dbstsbere: don't tell me, tell the commit
#09:47:07dbs suspects that it would be much easier for future people to read the commit log than to coordinate commit times with IRC logs :)
#09:50:55tsberedbs: I force-pushed a commit message. Better? ;)
#09:52:06dbsMuch! Would you be willing to put that comment into the code, too? :)
#09:52:38dbstsbere++ # for putting up with me
#09:52:44phasefx is going to start commenting his javascript in perl ;)
#09:54:38dbs sees a number of "if (!isNaN(Number(value))" checks elsewhere
#09:54:40tsberedbs: Added some comments. :P
#09:54:57Dyrcona will comment all code in erlang or lisp depending on mood.
#09:54:58dbsas well as a number of "if (!Number(value))" checks
#09:55:36sal_what, no APL? It's all Greek to us anyway ;-)
#09:56:07phasefx was bit by NaN != NaN
#09:56:25gmcharlt_eeevil: do you happen to know if PL/APL is available?
#09:56:35phasefx needs more keys on his keyboard
#09:57:43Dyrcona only believes code.
#10:10:08csharpspeaking of keys, does anyone know where I might find documentation on "hotkeys" in 2.1?
#10:10:26tsbere forgets if his customizable hotkeys are in 2.1
#10:11:21csharptsbere: doesn't look like it - options appear to be Default, Minimal, and None
#10:11:45csharpjust wondering what "Default" and "Minimal" mean
#10:12:22mrpeters-isljust pushed refs/heads/user/mrpeters-isl/tpac_semantic_amazon_record_details -- (live @ http://208.119.1.125/eg/opac/home)
#10:12:24tsberecsharp: That would be a "yes" then
#10:12:41tsberecsharp: They are defined in files in the staff client. Skin directory, hotkeys folder, I think?
#10:12:49mrpeters-islphasefx: thanks for the note on advanced tabs. fixed that last night.
#10:12:49csharptsbere: ah
#10:12:55csharpthanks
#10:14:23csharpJust got this when entering the "Work Log" interface: http://pastebin.com/9mfDdHTF
#10:15:00bjwebb has joined #evergreen
#10:15:00bjwebb has joined #evergreen
#10:24:22sal_ has quit IRC
#10:26:21moodaepo has quit IRC
#10:26:21moodaepo has joined #evergreen
#10:29:29mrpeters-islsmall ttpac thought...i think the logo in top left should always link to the "home" of the local catalog, rather than to evergreen-ils.org
#10:30:46phasefxcsharp: I'll poke at that
#10:30:55csharpphasefx: cool
#10:31:39csharpI haven't done any transactions on the workstation yet, if that affects anything
#10:34:47phasefxno, I missed something when I was ripping map_row_to_columns out of list invocations
#10:37:19bshummrpeters-isl: I would tend to agree with that opinion. The link at the bottom for powered by Evergreen points to the EG site anywho, so there's still a link back somewhere.
#10:38:55bshumtsbere: Is it possible to completely hide the hotkey button in the staff client, along with the menu links to it? (not sure we'd want to share that option with our libs right away)
#10:39:18dbsmrpeters-isl: it probably should (if by "home" you mean "web page of the particular library"), but one can do that at the skin level (and substitute the library's logo at the same time)
#10:39:19tsberebshum: Find the ID(s) for things, add a "display: none" custom CSS rule?
#10:39:24phasefxcsharp: if you git pull, a fix should come down
#10:39:34csharpyay
#10:39:38csharpgit++
#10:40:12bshumtsbere: Ah, that sounds good. Thanks! (not good at custom CSS yet, but should learn more...)
#10:40:50csharpoh and phasefx++
#10:40:53csharp:-D
#10:41:48phasefx will break things more often so he can fix them :)
#10:50:54phasefxthe tpac toggle in the portal page.. we need to enable SSL mode for the tpac for holds to work. There's a pref that already does this, oils.secure_opac, and I can enable it in constants.js when we test use_tpac. My question is whether we should bother preserving the original state of that pref for when we untoggle the tpac. I'm inclined to say no :) should probably make the entire staff
#10:50:54phasefxclient SSL anyway
#10:50:54sal_ has joined #evergreen
#10:52:08csharpphasefx: will that change require me to build a new staff client?
#10:53:14phasefxI don't think so. You could use Admin -> For Developers -> about:config now and set oils.secure_opac to true to fix things
#10:53:30csharpokay - thanks
#10:53:40phasefxhopefully
#10:54:25dbsmake_entire_staff_client_ssl++
#10:55:10csharpphasefx: worked - thanks
#10:55:22phasefxso, setting the pref doesn't effectively change anything without a restart
#10:57:18phasefxno, I'm wrong
#10:57:27phasefxcool deal
#11:01:48berickrunning the t-pac non-ssl inside the staff client is guaranteed to cause headaches.. make_entire_staff_client_ssl++
#11:02:42csharphey - I'd like to enable the t-pac and google's not helping - isn't there a wiki page around?
#11:02:43phasefxof course, we lose some caching benefits.. say I were to make browser.xul use SSL for any embedded interface, I think it'd be loading dojo over and over. I could be wrong
#11:03:49berickcsharp: running master?
#11:03:58csharprel_2_1
#11:04:19csharpah - found it
#11:04:26csharphttp://evergreen-ils.org/dokuwiki/doku.php?id=dev:opac:template-toolkit&s[]=template&s[]=toolkit
#11:04:30csharpfor the logs ;-)
#11:05:10berickcsharp: hate to dissapoint.. no can do in rel_2_1
#11:05:29csharpheh - that's okay
#11:05:37csharp weeps silently
#11:08:09berick grabs 0628
#11:12:29eeevilgmcharlt_: re pl/apl http://www.postgresql.org/docs/9.0/interactive/external-pl.html says no, and it was an april fools day joke in 2005: http://archives.postgresql.org/pgsql-announce/2005-04/msg00000.php ... :)
#11:15:27dbsI'm sure that was a feature in 9.1
#11:15:56dbsAlso, pl/miker
#11:21:18brian_f has joined #evergreen
#11:25:49eeevildbs: oh, that was renamed to pl/bf
#11:27:22dbs wonders if there are any appropriately licenced "what's new in Evergreen 2.1 / 2.2" presentations floating around
#11:29:57mrpeters-isldbs: i was just changing the href to "/eg/opac/home"
#11:30:03mrpeters-islso it always goes back to the home of the opac
#11:30:40mrpeters-isli loaded ttpac in 2.1...at least it appears i did?
#11:30:53dbsmrpeters-isl: yeah. the original KCLS skin linked to kcls.org, the home of the library, which makes the most sense to me. I really think it should just be part of a list of "creating a customized skin" action items
#11:30:55mrpeters-islhttp://dev.evergreen.lib.in.us/eg/opac/home is on 2.1
#11:31:35mrpeters-islfwiw it never linked anywhere in the current skin
#11:31:38mrpeters-islwas just an image
#11:32:04dbs looks at it linking to evergreen-ils.org
#11:32:18dbsfwiw
#11:32:24mrpeters-islthe one at bottom does
#11:32:56dbshttp://dev198.esilibrary.com/eg/opac/home agrees with me
#11:33:03dbsfwiw
#11:33:08mrpeters-islim talking about the old opac
#11:33:17mrpeters-islhttp://50.19.218.214/opac/en-US/skin/default/xml/advanced.xml?d=0 for example
#11:33:28dbs doesn't care about the old opac
#11:33:51mrpeters-isli think the "powered by" icon should link to the community, but i think the one in top left on all pages should go "home" or nowhere
#11:34:17mrpeters-islsomeone'll forget to change it and then phasefx will be annoyed because he's getting questions on the feedback form :)
#11:35:06phasefxmeh, annoyed by spam maybe
#11:35:14dbsopen-ils-spam list
#11:35:19mrpeters-isllol
#11:35:50csharp creates the list as requested
#11:36:05bshumSpeaking of lists.
#11:36:26bshumMarkmail search only looks at the 3 lists from before. Is there any way to change that to search the new ones that have been created too?
#11:36:52bshumOr at least, the markmail link that's on the site page somewhere...
#11:37:16mrpeters-isli was thinking some dropdowns like http://www.filamentgroup.com/examples/menus/flat.php would be really sharp
#11:38:02csharpbshum: I think we have to request that MarkMail add them
#11:38:11csharpI'm at their contact page now
#11:41:49bshumcsharp: Neat, I wasn't sure how many folks really want to search (or see) all of the mailing lists at the same time, but I like having that sort of option at my fingertips.
#11:44:50csharpokay - I requested that they add evergreen-reports and evergreen-web-team
#11:45:05bshumcsharp++
#11:45:07bshumThanks!
#11:48:05mrpeters-islhmmm active barcode in Personal Information seems to be showing my password hash instead of the barcode
#11:48:28phasefxmrpeters-isl: admin user?
#11:48:31mrpeters-islyes
#11:48:37mrpeters-islthat normal?
#11:48:41phasefxrandomly generated barcode
#11:48:54mrpeters-islaha ok got worried for a sec :)
#12:12:04mrpeters-islstaff client likes to render a nice ugly black border around the print-wrapper icons
#12:15:32mrpeters-islrather, printnav
#12:18:37kmlussier has quit IRC
#12:20:56dbsmrpeters-isl: that (printnav) is gone in my branch. maybe i should issue a merge request so we can worry about one style/skin instead of two
#12:22:27mrpeters-islah, see i like that little tab
#12:23:20dbsIt's just an INCLUDE away for people who like superfluous images
#12:24:13mrpeters-islyeah, only thing is we need to pull over my updated png's for it for those who do enable it
#12:24:14dbs notes that reporter HTML output should probably include UTF8 encoding declaration & will patch it so
#12:24:24mrpeters-islthe blue/grey ones wont match so well
#12:24:25DyrconaWhee! Rounding errors in Perl lead to fee payment problems in SIP2.
#12:35:29matt_carlson has joined #evergreen
#12:50:40AaronZ-PLS has joined #evergreen
#12:58:05dbset voila: bug + pullrequests for unicode in HTML report output at https://bugs.launchpad.net/evergreen/+bug/856567
#12:58:48bjwebb has quit IRC
#13:06:59dbs is pretty sure that we can drop the "how to use git" boilerplate from bug reports
#13:07:21berick+1
#13:08:17sal_Dyrcona: uh oh...
#13:08:52dbs could use a refresher in "how not to inadvertently create branches on mainline repo" though :0
#13:10:00tsberedbs: I came up with some more protection for that. Waiting on gmcharlt to do a final look. General idea is "For Evergreen and OpenSRF, only allow branches that start with rel_, tags/rel_, or topic/".
#13:39:49gmcharlt_tsbere: that's fine with me - go for it
#13:42:55tsberepushed!
#13:43:08gmcharlt_tsbere: and sorry, in my haste I had missed that you your initial push was to a topic branch in gitolite-admin
#13:43:12gmcharlt_tsbere++
#13:43:49tsberegmcharlt_: I don't like making changes like that without checking with you first. I think I created all the topic branches there......
#13:44:18tsbere checks
#13:44:23tsbereYep. Looks like I made them all. >_>
#13:46:55tsberedbs: I personally have no problem putting the boilerplates (I wrote the script to make them) but I do admit it is silly when branches are thrown around in launchpad and the boilerplate is the biggest chunk....
#13:47:17tsbere has had commits that he thinks are smaller than the boilerplate even when viewed as diffs
#13:47:22dbsYeah, I find it's noise
#13:48:50tsbereOn a different note, I made 2.1 versions of the suppress transits and statistical archive branches (by request). Anyone have desire to include new features this late? ;) :p
#13:49:28dbsWe'll just slip the TPAC into 2.1 too, okay?
#13:49:57dbsgit merge origin/master
#13:50:08tsbereAs far as MVLC is concerned we can skip 2.1 entirely. Say "nah, too many changes. We are going to just call the next one 2.2 and never have a 2.1" :P
#13:50:23DyrconaAnyone got any TPAC development branches that they think would be good to look at on my dev server?
#13:50:39DyrconaI've already merged dbs' amazon style display.
#13:51:16DyrconaAnd, yeah, we don't really care one way or the other about 2.1, but some of our "partners" do.
#13:51:57DyrconaThey think it will be more stable than master, but I fail to see how since no one really runs 2.1, but someone runs master in production.
#13:53:20Dyrconabtw, sal_, https://bugs.launchpad.net/evergreen/+bug/856566
#13:56:32edoceo has joined #evergreen
#13:57:31Dyrconaso, no other tpac branches for me to play with/break?
#13:58:03matt_carlson has quit IRC
#13:58:19sal_Dyrcona: testing tomorrow with a customer against their test server; assuming that patch will make it in before they go live in November. WIll patch my builds in the mean time :-)
#13:58:56senatorit'd be a good opportunity for someone to get some fresh eyes on something like that, but for my part i can't think of any outstanding branches atm
#13:59:11dbsDyrcona: mrpeters pushed working/user/mrpeters-isl/tpac_semantic_amazon_record_details a little while ago - a few commits on top of mine
#13:59:39Dyrconaok. i'll merger mrpeters branch into my dev branch.
#13:59:57Dyrconasal_: We'll use the bug fix branch in our next update, even if its not in master by then.
#13:59:58dbsjust don't hold anything he did to make it beautiful against me and my stark code
#14:00:14Dyrconadbs: np. :p
#14:02:00dbs(mrpeters does beautiful work)
#14:04:09DyrconaWaiting for "autopacking the repository to finish." Likely has by the time I've typed this.
#14:04:22matt_carlson has joined #evergreen
#14:11:32agJohn has joined #evergreen
#14:12:22mrpeters-islaw thanks dbs
#14:12:45moodaepotsbere: Quick question how would I set a default value in the patron registration form? I tried default='CA' but no luck with that.
#14:13:07tsberemoodaepo: You know, I never tried that. <_<
#14:13:14tsbere has no clue
#14:13:39moodaepo goes to look
#14:15:40agJohnHi Folks. Anyone else encountered errors with the 1.6.1-2.0 final partial reingest phase?
#14:15:42agJohnDrilling down to find the source of the problem, biblio.extract_metabib_field_entry is throwing:
#14:15:43agJohn Error: ERROR: could not create XPath object
#14:15:45agJohn Undefined namespace prefix
#14:15:47agJohn xmlXPathCompiledEval: evaluation failed;
#14:15:48agJohnI googled to see if there was anything about this, and all I see that seems related is a discussion back in Jan of '10 in which miker decides to reimplement
#14:15:50agJohn"xslt_process() as a simplified plperlu function". So, I'm not sure this is related.
#14:16:47agJohnIf this isn't a known problem, I'll paste all the info about it (I've ID specific entries in the lists of xpath entries that seem to be the source of my woes).
#14:17:17eeevilagJohn: likely the xpath in config.metabib_field needs to be updated to use the namespace prefix defined on the config.xslt_transform table
#14:17:26eeevilagJohn: as in, marc: vs marcxml:
#14:18:48agJohneeevil: Hmm. I think I'll do the paste. The entries that are problematic have 'marc' as their prefix. (Now I just gotta find my note about where you paste things....)
#14:19:15agJohnThe entries that fail look a whole lot like the ones that work....
#14:22:46tsberemoodaepo: what are you looking to default?
#14:23:47moodaepotsbere: Country & State - I also tried value='CA' but now I think I need to set it somewhere else
#14:24:00tsbereI think country has an org unit setting
#14:26:13tsberemoodaepo: In the DB, ui.patron.default_country exists. Nothing about default state.
#14:26:14moodaepoAh right that is already set
#14:27:38moodaepo off to a meeting for now
#14:29:08bjwebb has joined #evergreen
#14:37:59agJohnJust pasted some details on the "Undefined namespace prefix" error: http://paste.lisp.org/display/124785
#14:38:01agJohnI'd appreciate anyone's assistance who can take a few minutes to look at it.
#14:39:49agJohnHmmm. Just noticed that the unhappy rows use double-quotes around the tag number: //marcxml:datafield[@tag="590"]
#14:39:51agJohnWhere all others have single quotes around the tag numbers.
#14:39:52agJohnI'll see if that's the problem.
#14:40:45eeevilagJohn: it's the namespace prefix
#14:41:12eeevilthe ones marked Fail use "marcxml:" and the ones marked "Works" use "marc:"
#14:41:42eeevilagJohn: in the actual xpath
#14:42:05agJohnLooking in the wrong place for the namespace prefix--not the value called "prefix" in the function. I'm with you now.
#14:42:51agJohnThat rather suggests something went wrong in updating/inserting those rows in the upgrade script, does it not?
#14:43:38dbs wonders what version of the upgrade script agJohn is using
#14:44:29eeevilthe failing ones are local customizations, and the upgrade script almost certainly targets specific (stock) index defs
#14:44:59agJohnDownloaded the 2.0.9 source code on Monday or Tuesday--ah, looks like eeevil has figured it out.
#14:45:02eeevilit's just a matter of "we won't "fix" things we're not sure are incorrect"
#14:45:15agJohnCompletely understandable.
#14:46:16agJohnThere was undoubtedly a message that I blipped over telling me to check stuff like that....
#14:46:39agJohnAnother item to add to my troubleshooting notes....
#14:49:51sal_tsbere: a minor niggle that has always bugged me... re bug 720795 (https://bugs.launchpad.net/evergreen/+bug/720795) , how do I get the DoB to show up in the suggested/required fields when registering a patron? (Especially if the staff client keeps complaining about invalid DoB?)
#14:50:16tsberesal_: What version of EG?
#14:50:53sal_running off the master from last Monday?
#14:51:11sal_But I've seen it in everything from 2.0.5 up...
#14:51:29tsbereTurn on the DOB required setting in library settings editor. As for "invalid", it will default to your system's date format, but the global date format can override it.
#14:51:43sal_Thanks!
#14:52:17sal_Invalid is probably because there isn't one, rather than the format not matching...
#14:52:46sal_Will I have to rebuild the client, or will it pick up the library settings automagically?
#14:56:37Dyrconasal_: you won't have to rebuild the client, but you probably will have to log out and log back in.
#15:00:49_bott_ has quit IRC
#15:01:54dbsberick: i like the YAOUS; thinking about a similar YAOUS for "holds for this library's items can only be picked up at this library" - or disabling the hold pickup selection dialogue entirely, really
#15:01:56_bott_ has joined #evergreen
#15:04:22tsberedbs: Your desire there sounds great for copy/volume holds. How would you anticipate it working for title holds?
#15:04:58tsbereOr are you thinking a "you can only pick stuff up at your home library" type deal?
#15:05:22dbstsbere: roughly, pick up only at asset.copy.circ_lib, within given scope
#15:06:17dbsOur particular use case is a campus with about 9 different OUs. We don't ship items around between the OUs.
#15:06:57tsbereStill not sure how a title level hold can auto-pick the pickup location.
#15:07:28dbstsbere: Yes, it seems that holds are pretty broken for our use case
#15:08:34tsbere dislikes when the code does not meet known, documentable or documented use cases
#15:08:54dbsAmazingly, we've somehow survived for the past 2.5 years
#15:08:56tsbereknown but nobody can document use cases, on the other hand, can go jump in the nearest lake ;)
#15:09:59jeffone option for dbs' use case would be to enable volume holds and disable title holds -- possibly with a friendly "we found volumes at these two libs -- since we don't ship items, which library would you like to pick for your hold?"
#15:10:24jeffhog wild would be "doesn't matter, i'll pick it up at whichever library has it available first" :-)
#15:10:40dbsthe reality is that the bulk of our titles were per-library, including loads of dupes, so it hasn't really shown up in practice much. Yet.
#15:11:36tsbereHmm. Allow a null in the pickup_lib field. If it is null, it is picked up wherever it shows up, and the patron has to go fetch it. Wherever that may be! ;)
#15:11:37dbs needs to explore how volumes differ from sets in 2.1+ again
#15:12:04tsbere mentally translates "volume hold" to "call number hold" just to keep things straight
#15:12:31sal_general question: where are YAOUSs best implemented? (Still tweaking my "SIP item properties." Right now sticking stuff in oils_sip.xml->supports, and using SIP->supports() to check...)
#15:13:11tsberesal_: Where they are needed! Also in the EG side of the SIP code, not the SIPServer side.
#15:14:35eeevildbs: hard boundaries (and, if you're using it, transit distance restriction) doesn't work for you, re holds are broken? or don't do quite what you want?
#15:14:45jamesrfi think it would be nice if the holds pickup selector populated based on eligible pickup locations for that hold
#15:14:48dbseeevil: pickup location selector
#15:14:55eeevils/using it/using in-db hold matrix/
#15:15:18tsberejamesrf: That sounds like a headache waiting to happen.
#15:15:49jamesrfhow so? users shouldn't see the location if it's not a valid pickup location
#15:15:52eeevildbs: oh, broken from the "user can request impossible holds and keeps seeing the no-copies error" perspective
#15:15:53jeffjamesrf: incredibly useful, especially where you can't get away from policies that limit that kind of thing. i can see how it would quickly get complex fast.
#15:16:10dbseeevil: yeah
#15:16:23tsberejamesrf: Oh, I have no problem with the *user* end of it. The headache comes from the writing *code* end of it.
#15:16:32eeeviljamesrf: org hiding does that for sitka, right?
#15:16:36dbsjamesrf: i would want / hope to see that as a user, if we could make the backend part go away :)
#15:16:37jamesrfwell who are we writing the code for?
#15:17:17dbs has written no holds code because he doesn't really grok the more complex PINES-level scenarios and doesn't want to badly break them
#15:17:18jamesrfyeah we do org hiding but we have some additional hbacks
#15:17:22tsbereThe issue is to figure out the tree you have to run a full "can this hold be placed" for *every OU the user can possibly place the hold for*. With the same shortcuts out as that.
#15:18:09eeeviltsbere: for every pre-potenial copy at every OU ... :)
#15:18:11tsbereSo the user gets to wait six weeks for every OU to be tested across every copy that might fill. And if no copy will ever fill at an OU you have to wait for the backend to test *every copy*
#15:18:18dbs leans towards the reliably dumb "what copies can I see as this user right now? Okay, populate the list with those libs" for his simple use case
#15:19:09dbsstill all kinds of potential problems, of course. oh yeah. and of course we don't allow holds when items are available on the shelf.
#15:19:36tsbereThe "what copies came up when the user searched" method would be potentially useful, though.
#15:21:53tsberedbs: Does your use case include "people aren't at their 'home' library", or are people practically restricted to their "home" library?
#15:22:36eeevildbs: right ... org hiding helps with that, but you may not want to use it
#15:22:37dbstsbere: no, people can check items out from any of the campus libraries
#15:22:58dbs needs to look into org hiding too
#15:23:05dbs has a long list of "things to look into"
#15:23:14eeevil:)
#15:23:57jamesrfwe have found some crafty patrons have managed to escape the org unit hiding somehow
#15:24:45jamesrfwe haven't figured out how though
#15:25:00tsbereLogging into the wrong catalog?
#15:25:31jamesrfnope
#15:25:47tsbere doesn't have a use for that feature, so hasn't looked into it
#15:26:22jamesrfthey're noticing it in libraries, patrons are leaving the opac machine scoped consortia-wide
#15:26:55jamesrfapache logs are not helping
#15:28:16tsbereEditing the address bar to enter a depth of 0?
#15:28:52tsbereOr....does the org unit hiding change/suppress the "you got didlysquat for results, you want to expand to *everywhere*?" prompt? If that was missed....
#15:30:56sal_tsbere: I didn't have to do anything on the SIPServer side... Some forethoughtful developers had implemented the CH field already--if item.sip_item_properties exists, send it out as a CH.
#15:31:21jeffdoesn't seem to be that, but i've seen / heard reports of similar.
#15:31:35jeff(escaping org unit hiding, unintentionally)
#15:32:13jamesrftsbere: i think we've suppress the low hits thing although not sure if i've contribed that back as we had our own incarnation of org unit hiding prior to org unit hiding being added
#15:35:30Dyrconamrpeters-isl++ #tt-opac css changes
#15:40:10tsberehttp://git.mvlcstaff.org/?p=tsbere/ILS.git;a=shortlog;h=refs/heads/alt_app_name < mainly for Dyrcona who was saying he wants an ability to do that.
#15:45:25Dyrconatt-opac doesn't quite work with Firefox 3.6.22.
#15:46:34dbsDyrcona: definitions of "doesn't quite work" welcome; as well as sorting out whether it's my changes or mrpeters' changes that break it
#15:47:13dbs was thinking "bah, who is even going to have 3.6.22 around by the time TPAC is released" then realized -- oh, staff client
#15:47:26tsbereThe "Your name", "My Account", "Logout" area isn't showing up for him and he gets black boxes around nav points.
#15:47:45tsbere has no clue who's changes, if anyone's, are the problem, though
#15:49:55dbs wonders if that stuff is supposed to show up inside the staff client
#15:50:13tsbereFor added fun: He has no header div in the HTML source.
#15:50:24tsbere wonders if something caused the tpac to think he is *in* the staff client
#15:50:46Dyrconadbs: I don't think it was either of your changes. I seem to recall seeing this before loading your branches.
#15:51:12DyrconaI use FF 3.6.22 because I run lucid on the desktop and that's the package for lucid.
#15:51:26DyrconaLooks great in Chromium, though. :)
#15:53:22dbs develops with Firefox 6.0.2 and Chromium
#15:53:31DyrconaVoice search in Chromium is neat: Say, "Paulo Coelho" searches for "hello whale". :)
#15:54:59dbsvoice search works well for me with a headset
#15:57:49tspindler has quit IRC
#15:58:54Dyrconahaha. tsbere++
#15:58:59Dyrcona oils_xulrunner /xul/2_1_1mvlc_4/server/ was my user agent.
#15:59:38collum has quit IRC
#15:59:39dbsDyrcona: you're right, in xulrunner 1.9.2.17 the header is cut off too, and that's before my changes. bizarre
#15:59:41DyrconaI installed the extension at one point in time and the server thought I was running the staff client.
#15:59:53dbsSWEET
#15:59:57dbs doesn't worry anymore
#16:00:03tsbereI don't like this code anymore: $ctx->{is_staff} = ($self->apache->headers_in->get('User-Agent') =~ /oils_xulrunner/);
#16:00:33dbstsbere: that's solid security right there :)
#16:03:08Eric____ has joined #evergreen
#16:06:32senator$ctx->{is_staff} isn't (shouldn't) be used to indicate auth. just a matter of knowing whether to try staff-client operations and whether to draw certain things. auth needed for crud operations isn't affected
#16:07:04tsbereStill, IMO, a bad idea to use user agent for that. Especially if we decide to try and continue to support extension-mode.
#16:07:05dbssenator: I know, display only
#16:07:17senatorin other words, nothing sensitive should be hiding behind an if ($ctx->{is_staff}) test. it should be spelled out as is_staff_client so as not to suggest is_staff_user though
#16:08:19tsbere wonders if a better choice might be to check the authtoken for, say, workstation ID
#16:08:37tsbereThe staff client should never load pages without an authtoken...
#16:08:58phasefxsome non-staff client interfaces can have a workstation I believe
#16:09:03tsberehmm
#16:09:07bericknot sure how important it is, but I often log in with a workstation from the browser for devlopment purposes
#16:09:17berickwhat phasefx said
#16:10:20berickis extension-mode still a viable option?
#16:10:33berick thought the auto-update stuff effectively deprecated that
#16:10:39senatori thought that was history, too, but could be crazy
#16:10:40tsbereNot while we are stuck in 3.0ish xulrunner land
#16:11:00tsbereBut if we pull out of 3.0ish xulrunner land it would instantly become viable again, if we want it to.
#16:11:25berickgotcha
#16:11:35dbs googles "automatic XUL to Template::Toolkit conversion"
#16:11:44eeevilha!
#16:11:57eeevildbs: jaxer
#16:12:04senator shoots eeevil
#16:12:10eeevilhehehe
#16:12:59lisah_ has joined #evergreen
#16:13:29tsbere could write a very simple alternate solution based on a custom request header
#16:14:11tsbereAnd, in the process, rip out extension support as that solution kills any thoughts of using extension mode ;)
#16:16:09Eric____ has quit IRC
#16:16:15dbs needs to figure out why "Bib Call #" gets populated in Staff Client bib view with LC, but Call Number dropdown only shows Dewey
#16:20:35phasefxdbs: bib_brief_overlay.js, line 97
#16:20:56phasefxlooks like it's supposed to be using cat.default_classification_scheme
#16:24:18dbsphasefx: okay - so it uses class 1 by default, which picks the first CN it finds in the list (050ab,...), which makes sense - 050 is LC call number
#16:24:37dbsbut I thought the drop-down selector should be populated by all the matches for that list
#16:24:58dbsin vol/copy creator I mean :)
#16:25:08dbs will go look there
#16:27:54phasefxcat.util.render_callnumbers_for_bib_menu
#16:29:13dbsyep, I'm already there
#16:29:34dbssorry, should have let you know so you can focus on something else
#16:29:49phasefx obsesses
#16:31:28dbsopen-ils.cat.biblio.record.marc_cn.retrieve returns what it should
#16:31:59dbs wonders why only one call number out of the three that are returned is displayed in the menu
#16:32:23tsberebad loop? no loop?
#16:32:48phasefx wonders why call_number_class is in asset and not config :)
#16:33:23tsbereBecause lots of things don't live in sane places. :P
#16:34:27phasefxworking for me in my master
#16:34:29dbsis that like actor.org_unit_settings, or shell scripts in src/sql/
#16:34:48tsbereI don't know, actor.org_unit_settings isn't too bad, the types live in config.
#16:36:40dbsphasefx: via "Holdings Maintenance"? You pull in, say, Apache Derby and get two different call numbers to choose from?
#16:36:41phasefxwhat I'm not sure about is why it's defaulting to Dewey for me and not Generic
#16:37:08gdunbar has quit IRC
#16:37:21phasefxdbs: I handcrafted a record from New Marc with an 050, 082, 092.. then did Add Volumes from the record summary pane
#16:37:34dbs thinks "I need to configure that setting, let me go to config.actor_org_unit" all the time
#16:37:37phasefxI get the 082 and the 092
#16:37:52phasefxand my volume defaults to Dewey.. but I don't have the org setting set
#16:37:53dbsmaybe it's a difference in entry points, somehow
#16:38:29phasefxsame behavior for me from holdings maintenance
#16:38:43phasefx tries the bib mentioned
#16:39:11dbsYeah, i get the same bad behaviour from both entry points, using master
#16:41:00phasefxdbs: you're adding volumes.. which class are they defaulting to?
#16:41:29dbsphasefx: I have no class_scheme OUS set, so default/generic
#16:42:42phasefx has none set either, but is getting a 2
#16:43:01dbsyou're getting both call numbers in the drop-down?
#16:43:08phasefxno
#16:43:47phasefxif you control+shift+f7 while focused on say, the menu, and eval g.label_class, you get 1?
#16:45:21dbs gets 2
#16:45:39phasefxalright, it's pulling the class from the dummy acn passed in
#16:46:05dbsheh - "dvalue" is "dummy value"?
#16:46:18phasefxno, I got that wrong in my head
#16:46:26phasefxg.label_class = g.data.list.acnc[0].id();
#16:46:29phasefxit's doing that
#16:47:01phasefxwhich happens to be dewey
#16:47:34phasefxthe 2nd element is generic :)
#16:48:54phasefxso we need to put that in bib_brief_overlay for consistency.. or just use 1 instead
#16:50:21phasefxmake sense? with lack of org setting, we're default to 1 in the record summary pane, but default to the first fieldmapper object in an arbitrarily ordered list for the volume/copy creator
#16:52:01dbs is tired and make_menulist(foo.concat(map_list(bar, embedded function))) appears to be too much to grok atm
#16:53:01dbs thought the record summary pane was doing the right thing, but was still confused about why he's seeing only one entry in the "Call Number" selection widget
#16:53:13dbsnow even my faith in the record summary pane is dashed :)
#16:53:50moodaepo confirms FF 3.6.22 issue Dyrcona mentioned earlier. Looks great in Opera 11.51 on Ubuntu Lucid : )
#16:54:47phasefxthat google books preview issue I mentioned before, ended up putting a min-height on the preview div and that works by some voodoo magic
#16:55:26dbsCSS++
#16:55:28dbsCSS--
#16:56:26jeffmoodaepo: how much of YOUR audience / users are Opera 11.51 on Ubuntu Lucid? ;-)
#16:57:08moodaepojeff++ # Answer - 1 : )
#16:57:11dbs tracking back to where g.label_class gets set. slowly
#16:57:29dbsoh fun, nested ternaries
#16:58:08phasefxshow me syntactic sugar and everything is cake
#16:59:02dbsheh
#16:59:23tsbere rarely uses nested ternaries........unless he is looking to be especially confusing
#16:59:41tsbereor I don't know a better way to do it due to lack of experience with other constructs in the language
#17:01:31dbstsbere++
#17:02:21dbs has quit IRC
#17:05:22AaronZ-PLS has quit IRC
#17:09:18jeffgit sanity check: i want to test master with changes from branch1 branch2 branch3 -- create a new local branch from master, merge the other three branches, test, and nuke branch when finished and happy with the results?
#17:09:44jeff(as in, merge branch1 into my-temp-branch, then merge branch2 into my-temp-branch...)
#17:09:56tsbereor "git merge branch1 branch2 branch3" ;)
#17:10:03jeffgood to know!
#17:10:12jeffother than that timesaving shortcut, am i doing it right?
#17:10:20tsberePretty much.
#17:13:53fortin has joined #evergreen
#17:19:29jeffDyrcona: if you don't already have an approach, here's one method of handling floating point gotchas: http://paste.lisp.org/display/124788
#17:20:18jeffDyrcona: mostly the abs($foo-$bar) > 0.01 instead of $foo != $bar
#17:20:52Dyrconajeff: used sprintf("%.2f", $amount_paid) to truncate to 2 decimal points.
#17:30:28jeffthird option is to assume money/currency and multiply by 100 like various fine code does. :-)
#17:31:08jeffthe sprintf seems like it might trip up sometimes, but i can't think of an example, and it comes recommended by various sources like the perl cookbook.
#17:31:16Dyrcona has quit IRC
#17:31:27lisah_ has quit IRC
#17:36:15matt_carlson has quit IRC
#17:51:44sal_ has quit IRC
#18:01:44lisah_ has joined #evergreen
#18:15:26fortin has quit IRC
#18:31:43Dyrcona has joined #evergreen
#18:42:22matt_carlson has joined #evergreen
#18:46:51matt_carlson has quit IRC
#18:51:33matt_carlson has joined #evergreen
#18:52:31lisah_ has quit IRC
#18:55:54AaronZ-PLS has joined #evergreen
#18:58:21AaronZ-PLS has quit IRC
#19:29:13Dyrcona has quit IRC
#19:40:19bjwebb has quit IRC
#19:47:30lisah_ has joined #evergreen
#20:15:52lisah_ has quit IRC
#21:03:34matt_carlson has quit IRC
#23:14:47lisah_ has joined #evergreen
#23:54:13matt_carlson has joined #evergreen
#23:55:55lisah_ has quit IRC
#23:58:53matt_carlson has quit IRC
#23:59:27matt_carlson has joined #evergreen
< Wednesday, September 21st, 2011Raw Log FileFriday, September 23rd, 2011 >