| # | Time | Nick | Message |
|---|
| # | 00:44:27 | adbowling-isl has quit IRC |
| # | 01:12:37 | _deXter has joined #evergreen |
| # | 01:27:28 | suho has quit IRC |
| # | 01:29:19 | _deXter has quit IRC |
| # | 02:09:04 | phasefx | @later tell tsbere I like the idea of having the labels on the commands, so that multiple widgets referencing the command (say a main menuitem and a context menuitem) can share the label with less duplication of text in the file. Exceptions can be made for when we don't want such sharing |
| # | 02:09:04 | pinesol` | phasefx: The operation succeeded. |
| # | 02:10:53 | phasefx | @later tell tsbere I didn't really grok the attribute forwarding properties of command when I first started, or I would have done that from the start |
| # | 02:10:53 | pinesol` | phasefx: The operation succeeded. |
| # | 07:57:32 | tsbere | @later tell phasefx There are issues with putting label/accesskey on commands only, though, meaning some will be on menuitems still. Such as patron by barcode that exists as three "functions": Checkout item, Retrieve Patron by Barcode, Search for Patron by Barcode. Which should be the "primary" on the command node? |
| # | 07:57:32 | pinesol` | tsbere: The operation succeeded. |
| # | 09:57:43 | tsbere | @later tell phasefx Also, the label (accesskey not being that useful) also may apply to toolbar buttons with the same command. Which in some cases use the same language string, in others use a shorter one? |
| # | 09:57:43 | pinesol` | tsbere: The operation succeeded. |
| # | 10:02:00 | flopaul has joined #evergreen |
| # | 10:05:43 | rjackson-isl has joined #evergreen |
| # | 10:08:08 | rjackson-isl | Good Sunday morning - was wondering if anyone is online that has had experience migrating a library onto 2.0.x? |
| # | 10:08:25 | rjackson-isl | WHen the copy of bibs starts up it never seems to finish |
| # | 10:08:40 | rjackson-isl | been running for over 15 hours now - about 30K bibs |
| # | 10:09:32 | flopaul has quit IRC |
| # | 10:15:51 | Dyrcona has joined #evergreen |
| # | 10:16:55 | suho has joined #evergreen |
| # | 11:10:44 | Dyrcona | Is there a good reason that there is no foreign key constraint on asset.copy in action.circulation? |
| # | 11:11:04 | Dyrcona | I was able to load 325,000+ circulations without any copies in the database. |
| # | 11:11:16 | eeevil | Dyrcona: yes. serial.unit.id could be used there |
| # | 11:12:15 | Dyrcona | ok, then. makes sense and you can't make a foreign key that references either of two other tables. |
| # | 11:12:24 | eeevil | right |
| # | 11:12:30 | Dyrcona | now, i vaguely remember discussing this or something like it months ago. |
| # | 11:13:14 | eeevil | we could use a check constraint of BEFORE trigger, though. the letter being more "correct" |
| # | 11:13:49 | Dyrcona | yeah. a before trigger.... |
| # | 11:14:20 | Dyrcona | i'll see if i can come up with a good one in between the thousand other things that i'm doing this week/weekend. |
| # | 11:14:44 | eeevil | :) |
| # | 11:15:27 | Dyrcona | just a had a load blow up because of a typo in a query. we were going to update our demo server with newer code and data. |
| # | 11:16:01 | bjwebb has joined #evergreen |
| # | 11:16:24 | Dyrcona | that's how i saw the circulations created with no copies. |
| # | 11:17:09 | tsbere missed a typo and accidently wiped out 20 minutes of work and missed it for 3 git commits |
| # | 11:18:56 | tsbere | Oh well. Now that I know what I am doing it is a set of 3 or 4 sed commands. |
| # | 11:20:23 | Dyrcona | sed is the answer to which is more powerful: vi or emacs. |
| # | 11:22:04 | eeevil | grabbing 0507 |
| # | 11:28:32 | phasefx | tsbere: if you anticipate the need for separate labels for widgets using the same command, I say go ahead and use separate DTD's directly on the widget. Is that what you're asking/getting at? |
| # | 11:29:06 | phasefx | ah, two later's <reads> |
| # | 11:29:12 | tsbere | phasefx: I am saying there are 8 (1 commented out) cmd_blah IDs being used with multiple labels/accesskeys in the menus. |
| # | 11:31:28 | phasefx | and what are you wanting my opinion on? |
| # | 11:34:13 | tsbere | How do I determine which of the conflicting labels goes on the <command> node? |
| # | 11:34:27 | tsbere | Or do I not put any on there and leave all of them on the menuitems? |
| # | 11:34:32 | phasefx | I think that |
| # | 11:34:37 | phasefx | the latter |
| # | 11:35:08 | phasefx | if the entities are different, I probably wanted to give translators an option to distinguish between context |
| # | 11:35:37 | tsbere | Take note, if there is something on the menuitem it should override the command node. |
| # | 11:35:38 | phasefx | but I don't really know how much of that is needed, and probably haven't been consistent in that regard |
| # | 11:35:49 | phasefx | ah |
| # | 11:35:54 | tsbere | So the "default" can be on the command node |
| # | 11:36:06 | tsbere | Which brings me back to "which one should be the default?" |
| # | 11:36:39 | tsbere notes that there are technically 9 commands with multiple menu entries, commented out or otherwise, but cmd_replace_barcode uses the same languge string 3 times |
| # | 11:36:56 | phasefx | I think if we want to do that, then any arbitrary rule is probably as good as any other. First occurance is the default? Last occurance? |
| # | 11:37:32 | tsbere | Occurance that seems to most closely match the name of the command in the english translation? |
| # | 11:37:39 | phasefx | tsbere++ btw, for getting an itch to clean things up |
| # | 11:37:48 | phasefx | that sounds good to me too |
| # | 11:38:41 | tsbere | This is part of an ongoing "prep" for an extension or feature to do major messing with the menus (and maybe toolbar) |
| # | 11:38:46 | phasefx | or, most prominent widget |
| # | 11:39:27 | phasefx | prominent or easiest widget to get to |
| # | 11:39:29 | tsbere | BTW, figured out that for toolbar use you can put the image= on the command too. Think I should move those while I am at it? |
| # | 11:40:57 | phasefx | tsbere: a little more iffy on images than labels. Let's say you want to have a dropdown menu on the toolbar that lists all toolbar commands, even if the toolbar is hiding some icons |
| # | 11:41:53 | phasefx | but I'm fine with changing things when you need to, and keeping stuff consistent/easy to find otherwise. So could have images on commands until and if they become an issue being there |
| # | 11:41:55 | tsbere notes that menu items don't show icons at all unless they have menuitem-iconic as a class, and thus ignore the image setting |
| # | 11:42:58 | phasefx | tsbere: I think you have more of a grip on this than I do; if you want to trailblaze I say have at it |
| # | 11:44:25 | flopaul has joined #evergreen |
| # | 11:45:14 | tsbere | BTW, is there an easy way from the javascript layer to check permissions? |
| # | 11:46:09 | phasefx | I never wrapped such checks in a utility function, but berick may have in the opac code |
| # | 11:47:41 | phasefx | the dojo stuff may have it wrapped up nice too, not sure |
| # | 11:49:14 | tsbere | I am considering a "assign one or more permissions to each command node in a new custom attribute, then iterate over them on window open and disable any that the user doesn't have the permission for" addition |
| # | 11:50:21 | tsbere | Maybe cache somewhere so that it isn't doing it all the time |
| # | 11:50:25 | phasefx | there should be a batch perms check |
| # | 11:50:34 | tsbere | Would need to re-run the check on new operator, though |
| # | 11:52:36 | tsbere | I don't see much in the way of batch check. Hmmm. |
| # | 11:52:52 | phasefx | open-ils.actor.user.has_work_perm_at.batch |
| # | 11:53:02 | phasefx | I think that may do what you need |
| # | 11:53:24 | tsbere would probably do better if he spelled "batch" correctly when grepping |
| # | 12:00:33 | suhothayan has joined #evergreen |
| # | 12:03:56 | suho has quit IRC |
| # | 12:04:17 | flopaul has quit IRC |
| # | 12:23:40 | suhothayan is now known as suho |
| # | 12:52:09 | Dyrcona | hmm.... apparently postgres doesn't handle "not null default value" the same way that some other databases do. |
| # | 12:52:27 | Dyrcona | it gives an error when i insert NULL, rather than use the default value. |
| # | 12:53:50 | phasefx | yeah, I've noticed that |
| # | 12:54:21 | Dyrcona | kind of a pita when every other database i use would use the default. |
| # | 12:54:30 | phasefx | I think you can insert DEFAULT in psql |
| # | 12:56:27 | tsbere | phasefx: I have a client_menus branch in my git repo, if you want to see/comment on what I have done so far. http://git.mvlcstaff.org/?p=tsbere/ILS.git;a=shortlog;h=refs/heads/client_menus |
| # | 12:57:09 | phasefx | tsbere: cool deal |
| # | 12:59:13 | tsbere is happy he knows sed and vim regex replace because otherwise some of that would have taken days |
| # | 13:00:38 | tsbere | phasefx: Also, the current state (3 commits on it) should (given a quick test or two) be safe and equiv to what was there from the other side of things. Thus commitable to trunk if you wanted to. |
| # | 13:01:20 | tsbere | phasefx: Ok, it breaks the label change on operator swap. *grumble* |
| # | 13:02:13 | tsbere takes a much closer look and wonders if he broke labels, or the *slight* upgrade to xulrunner he did in the process changed something |
| # | 13:02:41 | phasefx | hotkeys still work after removing @key? |
| # | 13:03:51 | tsbere | command nodes ignore key=. Hotkeys work without them. However, between the two versions of xulrunner command node labels started to *override* other labels, like on toolbar buttons and menu items. |
| # | 13:04:03 | tsbere grumbles |
| # | 13:04:23 | phasefx | fun |
| # | 13:04:39 | tsbere | Luckily that was a different commit |
| # | 13:04:44 | tsbere | and can thus be reverted easily enough |
| # | 13:05:01 | tsbere | Given that, though, should I go the other way and put them on the menuitems? |
| # | 13:05:37 | phasefx | for the multi-label case or for all cases? |
| # | 13:06:16 | tsbere | In all cases, so that you don't run into "I want a shorter one for this toolbar button" and it won't let you. |
| # | 13:06:21 | tsbere | Or other similar things |
| # | 13:07:47 | phasefx | well, I'm torn. In either case, if you need a different label, you're going to be editing some xul. But I like things on command for the majority of cases, just because it makes the files smaller, and gives xmlent less work to do. But if everything is on menuitems, etc., then at least it's consistent and more comprehensible for newcomers |
| # | 13:08:51 | tsbere | With them on the items using the label you don't run into "I edited this *other* file (where the toolbars are) and can't set/change a label" issues too. |
| # | 13:08:52 | phasefx | maybe see what the convention is in Firefox, Thunderbird |
| # | 13:09:44 | tsbere notes that he aims to make it so that almost anything in the menus can be given a toolbar button, and thus may want to mess with labels a lot more than is currently done in that regard |
| # | 13:11:18 | phasefx | if it makes things easier for you to not have stuff on command, then go for it |
| # | 13:16:40 | tsbere | Pushed another commit to swing things the other way |
| # | 13:16:58 | tsbere | Although I think I restored a pile of oldaccesskey type settings in the process. |
| # | 13:19:48 | phasefx | my way of commenting out attributes. Probably a bad habit with VCS's |
| # | 13:20:39 | tsbere | Maybe. I only removed them because my regex stuff moved them to the command nodes and I was sanitizing the command nodes. |
| # | 13:20:49 | tsbere | Hence reverting that change putting them back |
| # | 13:22:40 | tsbere | I suspect before commit to svn that some squashing is going to be needed |
| # | 13:51:16 | bjwebb has quit IRC |
| # | 14:45:33 | rsinger has quit IRC |
| # | 15:40:19 | suho has quit IRC |
| # | 15:57:27 | rsinger has joined #evergreen |
| # | 16:19:58 | Dyrcona has quit IRC |
| # | 16:21:46 | Dyrcona has joined #evergreen |
| # | 16:49:19 | eeevil | denials: curious ... what's authority field 148 from? what cataloging standard, I mean |
| # | 17:08:32 | Dyrcona | eeevil: Where should a before trigger on action.circulation go that requires the asset and serials schemas both be loaded first, i.e. what file? |
| # | 17:09:46 | Dyrcona | eeevil: Unless I hear otherwise, i'll put it in 800.fkeys.sql. |
| # | 17:09:59 | eeevil | Dyrcona: you could put it in 800.fkeys.sql, since it's implementing an inherited-table fkey of sorts |
| # | 17:10:03 | eeevil | yeah |
| # | 17:10:10 | Dyrcona | :) |
| # | 17:10:57 | eeevil | and you don't have to check them separately, you can just do SELECT TRUE FROM asset.copy WHERE id = $1 or equiv |
| # | 17:11:28 | eeevil | that will find the id in asset.copy or any child table (only serial.unit for now, but others could be added later) |
| # | 17:12:02 | eeevil | the fkey checks are essentially SELECT TRUE FROM ONLY asset.copy WHERE id = $1 |
| # | 17:12:08 | eeevil | (note the ONLY keyword) |
| # | 17:13:08 | eeevil | now, if you want it to be deferrable you can use an AFTER trigger and raise an exception from within the function |
| # | 17:13:38 | eeevil | that might be closer to what we want, as we almost always say DEFERRABLE INITIALLY DEFERRED |
| # | 17:14:44 | eeevil | (it's not really DEFERRED, but it at least allows BEFORE triggers to fill in the data before checking for it) |
| # | 17:15:16 | Dyrcona | will an after trigger that raises an exception prevent the bad data going in? |
| # | 17:16:13 | Dyrcona | i also see that there was a set null on the foreign key constraint that is commented out. should I try to support that and allow the target copy id to be null? |
| # | 17:17:07 | eeevil | Dyrcona: well, you can't really delete asset.copy objects, they're protected by a RULE |
| # | 17:17:17 | eeevil | so, I don't think that's necessary |
| # | 17:17:30 | Dyrcona | ok |
| # | 17:17:37 | eeevil | is the field currently nullable? |
| # | 17:17:43 | eeevil | if so, /that/ should be supported, yes |
| # | 17:17:55 | eeevil | but not the ON CASCADE SET NULL |
| # | 17:18:07 | eeevil | er, ON DELETE SET NULL |
| # | 17:18:22 | Dyrcona | no, it isn't, it turns out |
| # | 17:18:31 | eeevil | k |
| # | 17:18:53 | eeevil | so, a simple constraint that checks to see if asset.copy and kids has that value in the id field is enough |
| # | 17:19:20 | eeevil | denials: I found the 148, btw, no worries |
| # | 18:04:30 | Dyrcona | eeevil: git://git.mvlcstaff.org/jason/ILS branch ac_target_copy_trig |
| # | 18:16:43 | suho has joined #evergreen |
| # | 18:18:31 | suho has quit IRC |
| # | 18:20:30 | Dyrcona | created a launchpad bug anyway. |
| # | 18:26:30 | Dyrcona | that is more than enough for today. |
| # | 18:26:56 | Dyrcona has quit IRC |
| # | 19:08:16 | Digital_Pioneer creates an Android app for Evergreen with all the functionality of Hello World. |
| # | 19:10:04 | tsbere notes that Digital_Pioneer has more functionality than he does when it comes to an Android app doing anything right now |
| # | 19:10:16 | Digital_Pioneer | :D |
| # | 19:10:38 | Digital_Pioneer | It seemed reasonable to make something that proves I can at least put something on the device. |
| # | 19:10:44 | tsbere | True |
| # | 19:14:28 | Digital_Pioneer ships said app to his phone. It worx. |
| # | 19:15:02 | Digital_Pioneer | Let's see, here... I need an icon. |
| # | 19:15:54 | Digital_Pioneer | Does Evergreen have an official logo? |
| # | 19:16:27 | Digital_Pioneer | And does anyone happen to know where I could get a nice SVG of it? :P |
| # | 19:27:49 | tsbere | Hmmm |
| # | 19:28:39 | tsbere | We have .ico files in the staff client folder |
| # | 19:29:44 | Digital_Pioneer | Ehh. I'll just take the little emblem on the homepage logo. |
| # | 19:30:02 | tsbere had some source files kicking around |
| # | 19:30:24 | bshum | The main Evergreen logo info is here: http://www.georgialibraries.org/lib/pines/evergreenlogo/ |
| # | 19:30:35 | bshum | But that icon for the staff client is the usual one, right? |
| # | 19:31:15 | bshum | For an app icon, that seems like the best choice |
| # | 19:31:16 | tsbere | The icons in the staff client folder were created by mrpeters-isl, I think. I have the eps source files and some large png files I just found too. |
| # | 19:33:52 | senator_ has joined #evergreen |
| # | 19:35:39 | finnapz2 has quit IRC |
| # | 19:35:43 | senator has quit IRC |
| # | 19:37:14 | finnapz2 has joined #evergreen |
| # | 19:49:33 | tsbere_ has joined #evergreen |
| # | 19:51:41 | tsbere has quit IRC |
| # | 19:51:41 | rjackson-isl has quit IRC |
| # | 19:51:44 | eeevil has quit IRC |
| # | 19:51:46 | agJohn has quit IRC |
| # | 19:51:46 | Callender has quit IRC |
| # | 19:52:38 | Callender_ has joined #evergreen |
| # | 19:52:39 | eeevil_ has joined #evergreen |
| # | 19:52:44 | JMCraig has joined #evergreen |
| # | 19:52:45 | Callender_ is now known as Callender |
| # | 19:52:45 | JMCraig is now known as agJohn |
| # | 19:55:09 | eeevil_ is now known as eeevil |
| # | 19:55:43 | Jbergy has joined #evergreen |
| # | 20:03:52 | Jbergy has quit IRC |
| # | 20:04:17 | leed-home has quit IRC |
| # | 20:07:21 | Digital_Pioneer | I made this for the Android launcher icon. If anyone wants to make something else, feel free, and I'll put it in. Here's mine: http://dl.dropbox.com/u/453116/icon.png |
| # | 20:12:30 | leed-home has joined #evergreen |
| # | 20:14:21 | bshum | Digital_Pioneer: From trunk, I think this is what tsbere was referring to - http://svn.open-ils.org/trac/ILS/browser/trunk/Open-ILS/xul/staff_client/evergreen-icon.ico |
| # | 20:14:27 | bshum | Digital_Pioneer: Nice icon though :) |
| # | 20:38:34 | finnapz has quit IRC |
| # | 20:38:42 | mrpeters-isl has quit IRC |
| # | 20:38:54 | mrpeters-isl has joined #evergreen |
| # | 20:38:57 | finnapz has joined #evergreen |
| # | 20:40:00 | flopaul has joined #evergreen |
| # | 20:51:23 | tsbere_ | bshum / Digital_Pioneer : I have the eps files from mrpeters-isl for the one in trunk. And the beta variant. Dunno where they may live in a repo, if anywhere. |
| # | 21:00:45 | Dmagick has quit IRC |
| # | 21:01:54 | Dmagick has joined #evergreen |
| # | 21:02:10 | atheos has quit IRC |
| # | 21:02:11 | mjgiarlo has quit IRC |
| # | 21:02:37 | moodaepo has quit IRC |
| # | 21:03:39 | moodaepo has joined #evergreen |
| # | 21:07:33 | atheos has joined #evergreen |
| # | 21:25:01 | flopaul has quit IRC |
| # | 21:31:49 | Digital_Pioneer | bshum: Yeah, but mine is more compliant with the Android icon standards (as I made it with them in mind). |
| # | 21:32:21 | Digital_Pioneer | That said, an icon is an icon. :P I can use that one if you think it would be better. |
| # | 21:36:45 | tsbere_ | @later tell phasefx I updated my client_menus branch with the ability to set permissions on command nodes. No permission = command node disabled. Command node disabled = menu/toolbar items/hotkeys auto-disabled. |
| # | 21:36:45 | pinesol` | tsbere_: The operation succeeded. |
| # | 21:36:50 | tsbere_ is now known as tsbere |
| # | 21:46:46 | flopaul has joined #evergreen |
| # | 21:58:33 | flopaul has quit IRC |
| # | 22:23:36 | artunit_ has joined #evergreen |
| # | 22:27:16 | artunit has quit IRC |
| # | 22:27:28 | artunit_ is now known as artunit |
| # | 22:54:24 | dbwells_ has joined #evergreen |
| # | 22:55:17 | atz_ has quit IRC |
| # | 22:55:17 | mtate has quit IRC |
| # | 22:55:20 | dbwells has quit IRC |
| # | 22:55:21 | eby has quit IRC |
| # | 22:55:21 | phasefx_ has quit IRC |
| # | 22:55:23 | kbeswick has quit IRC |
| # | 22:55:27 | dbwells_ is now known as dbwells |
| # | 22:55:29 | atz_ has joined #evergreen |
| # | 23:00:55 | tsbere has quit IRC |
| # | 23:01:00 | sylvar has quit IRC |
| # | 23:01:01 | leed has quit IRC |
| # | 23:01:03 | csharp has quit IRC |
| # | 23:04:32 | kbeswick has joined #evergreen |
| # | 23:04:35 | eby has joined #evergreen |
| # | 23:04:37 | phasefx_ has joined #evergreen |
| # | 23:04:52 | tsbere has joined #evergreen |
| # | 23:04:52 | csharp has joined #evergreen |
| # | 23:04:52 | sylvar has joined #evergreen |
| # | 23:04:52 | leed has joined #evergreen |
| # | 23:05:02 | mtate has joined #evergreen |
| # | 23:26:54 | rangi` has joined #evergreen |
| # | 23:27:20 | _bott_1 has joined #evergreen |
| # | 23:28:49 | bshum_ has joined #evergreen |
| # | 23:31:16 | bshum_ has left #evergreen |
| # | 23:32:41 | AaronZ-PLS has quit IRC |
| # | 23:32:46 | _bott_ has quit IRC |
| # | 23:32:46 | bshum has quit IRC |
| # | 23:32:46 | rangi has quit IRC |
| # | 23:32:46 | jeff has quit IRC |
| # | 23:36:54 | jeff has joined #evergreen |
| # | 23:36:54 | jeff has joined #evergreen |
| # | 23:38:14 | bshum has joined #evergreen |
| # | 23:55:22 | mtisi_ has joined #evergreen |
| # | 23:55:30 | mtisi has quit IRC |
April 10-13