2008-02-08T00:35:39 *** tristanbob__ has quit IRC 2008-02-08T01:28:03 That modeline thinghy makes sense, there's been security concerns with it in the past, so that might explain it. 2008-02-08T08:01:28 *** greg-g has joined #openils-evergreen 2008-02-08T08:36:50 *** edc_detached is now known as ec0rrado 2008-02-08T08:50:21 *** dbs has joined #OpenILS-Evergreen 2008-02-08T09:01:02 *** Karen_ has joined #OpenILS-Evergreen 2008-02-08T09:27:51 *** dbs has quit IRC 2008-02-08T11:19:08 *** gsf has joined #openils-evergreen 2008-02-08T11:40:56 *** dbs has joined #OpenILS-Evergreen 2008-02-08T11:52:19 *** ec0rrado is now known as edc_detached 2008-02-08T12:35:50 excellent, I'm getting bites on my documentation offer :D 2008-02-08T12:36:09 phasefx_: woo hoo! 2008-02-08T12:36:34 3 bites 2008-02-08T12:36:47 * gsf is tempted to take phasefx_ up as well 2008-02-08T12:36:51 wow, holy moly 2008-02-08T12:37:02 haha, I asked for it 2008-02-08T12:37:13 Who can pass up free training, eh? 2008-02-08T12:37:20 dbs: and i'm trying to think of the most obnoxious format to send docs to you in 2008-02-08T12:37:23 Maybe I'll send some of our people your way... 2008-02-08T12:37:29 I wonder if it would still be personal if I handled 3 or 4 at a time 2008-02-08T12:37:40 gsf: pencil crayon on used facial tissues? 2008-02-08T12:37:40 dbs: but you already mentioned word, so there's nowhere to go, really 2008-02-08T12:37:57 dbs: yeah, but faxed 2008-02-08T12:38:09 faxial tissues? 2008-02-08T12:40:23 dbs: I train folks and you coordinate their documentation efforts? 2008-02-08T12:40:48 phasefx_: sounds like as good a plan as any 2008-02-08T12:41:04 dbs++ 2008-02-08T12:45:00 I really need to get the U of Michigan moving along with a test install for the LIS students to help with that documentation call 2008-02-08T12:46:25 Sounds like I should get that "20 minute install" video together - maybe we could use that for the code4lib evergreen workshop 2008-02-08T12:46:42 greg-g: have you installed evergreen before? 2008-02-08T12:48:43 dbs: I have not 2008-02-08T12:49:03 it has been a busy couple of semesters 2008-02-08T12:49:17 greg-g: I understand :) 2008-02-08T12:49:41 Off to buy and install some software. Whee. 2008-02-08T12:50:13 are the vm images still updated? 2008-02-08T12:55:35 gsf: I'm going to push all the volunteers together onto a mailing list or google group so we can hash out some good times, etc. You want in? 2008-02-08T12:56:58 phasefx_: mind if I just lurk on the list for now? 2008-02-08T12:57:51 greg-g: don't mind at all 2008-02-08T12:58:06 maybe I shouldn't do a new list, just [doc-effort] a topic on OPEN-ILS-DEV 2008-02-08T12:58:42 * Sarkastic loves topic-separating lists 2008-02-08T12:58:44 * greg-g needs to rejoin the -dev list 2008-02-08T12:58:44 well, schedule juggling need not be public :) 2008-02-08T13:00:21 phasefx_: if you're going to do a list, please make it a list on the "official" open-ils list server ... google groups are fine, but keeping the lists in one place makes for better findability in the long run, IMO 2008-02-08T13:00:50 * Sarkastic agrees 2008-02-08T13:00:53 (and I like the idea of another list, btw -- docs are very different than dev, IMO) 2008-02-08T13:01:19 ok miker_... You've met the requirements of my bribe... thanks ;) 2008-02-08T13:03:48 roger that 2008-02-08T13:04:08 Sarkastic: har! 2008-02-08T13:06:38 greg-g: vmware is pretty close to up to date 2008-02-08T13:07:23 I could push out an updated debian image pretty easily 2008-02-08T13:08:16 (yay! no copies of adobe were in our uni's computer shop, so I don't have to work on that today) 2008-02-08T13:09:18 dbs: that day == the day Adobe was going to escort the cops in to arrest you hippie academic pirates? 2008-02-08T13:10:00 hippies vs. libertarians - to the death! 2008-02-08T13:12:10 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T13:13:08 I know hippies, and you sir are NO hippie! ;) 2008-02-08T13:17:19 phasefx_: i still need to set up a vanilla debian etch box, but go ahead and add me -- gsf747@gmail 2008-02-08T13:20:02 gsf: ubuntu gutsy is fine too 2008-02-08T13:21:09 miker_: there are pictures from the late 80's (oh my god) that would argue otherwise 2008-02-08T13:35:00 btw - working on bill ott's error report - i've been seeing the same things for checkin, so i might as well scratch that itch 2008-02-08T14:19:05 *** gpal has joined #openils-evergreen 2008-02-08T14:36:26 gsf: will do. Btw, this list is being publically logged, do you want me to redact your email addie? 2008-02-08T14:37:34 phasefx_: no, it's fine 2008-02-08T14:38:18 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T14:38:26 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T14:38:45 dan.scott@acm.org dan@coffeecode.net kinetix@sympatico.ca dscott@laurentian.ca 2008-02-08T14:38:49 hahaa 2008-02-08T14:38:50 dbs++ 2008-02-08T14:38:51 HARVEST AWAY, FOOLS! 2008-02-08T14:39:00 root@localhost 2008-02-08T14:39:06 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T15:13:53 *** gpal has quit IRC 2008-02-08T15:37:50 well, I've rolled all the way back to rev. 8352 and still get details.copy has no properties for copy status check 2008-02-08T15:38:26 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T15:38:40 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T15:38:57 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T15:39:44 Sarkastic: I liked you better when you were dmcmorris 2008-02-08T15:40:19 *** Sarkastic is now known as dmcmorris_esi 2008-02-08T15:40:36 mind you i only rolled the staff client back to 8352 - so it's probably the behaviour of one of the opensrf methods that's changed 2008-02-08T15:40:50 * berick looks around 2008-02-08T15:41:09 oh yeah... berick's back... so we can't blame everything on him anymore 2008-02-08T15:41:43 Unit tests! Unit tests! My kingdom for some unit tests! 2008-02-08T15:41:55 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T15:42:27 btw - I put forward a proposal to our library council that I mentor a few Google Summer of Code students for unit test & documentation purposes this morning 2008-02-08T15:43:11 assuming that GSoC runs again this year, let's see if we can snag some students 2008-02-08T15:46:23 snag snag snag 2008-02-08T15:53:50 well duh... ** copy_details() isn't there. Please create me somewhere (like in OpenILS::Application)! 2008-02-08T15:55:48 dbs: what app is that in? 2008-02-08T15:56:01 Circ.pm:893 2008-02-08T15:56:24 this is freaking me out, seriously 2008-02-08T15:56:33 berick: it's freaking me out a bit, too 2008-02-08T15:56:34 dbs: do you see 'sub copy_details' about 10 lines down? 2008-02-08T15:56:38 yes 2008-02-08T15:56:44 what the heck changed? 2008-02-08T15:56:48 wtf 2008-02-08T15:58:16 * dbs looks at miker_'s change to subclass OpenSRF::Application with suspicion 2008-02-08T15:58:21 two things come to mind. the move to 'use base qw/OpenILS::Application/' vs. OpenSRF::Application .. 2008-02-08T15:58:24 heh 2008-02-08T15:58:36 another change too.. the addition of 'authoritative' methods 2008-02-08T15:58:41 s/methods/method handline/ 2008-02-08T15:58:45 handling 2008-02-08T15:59:03 nothing jumps out as to why it would break things, but those are recent changes 2008-02-08T15:59:20 I'll look too 2008-02-08T16:00:38 um ... I wouldn't call copy details like that, were I you ... 2008-02-08T16:01:05 I'd either use method_lookup, or just call it directly, with no indirection 2008-02-08T16:01:13 why? 2008-02-08T16:01:15 because self may not be what you are expecting 2008-02-08T16:01:25 it sure isn't in the .authoritative case 2008-02-08T16:01:36 in that case it's an instance of OpenILS::Application 2008-02-08T16:02:25 that concerns me that $self isn't OpenILS::Application::Circ inside of that package now 2008-02-08T16:02:37 hmm 2008-02-08T16:02:53 you're assuming too much there (that's actually one of the two the exact reason for method_lookup) ... just say return copy_details($self, $conn, $auth, $cid); 2008-02-08T16:03:15 berick: that was never a assured 2008-02-08T16:03:40 that's why I use the var name $client instead of $self 2008-02-08T16:03:44 because $self is confusing 2008-02-08T16:04:35 this is very confusing from an OO perspective 2008-02-08T16:04:48 that's because it's not OO 2008-02-08T16:04:55 ;) 2008-02-08T16:05:09 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T16:05:18 this is enlightening for me, at least 2008-02-08T16:05:24 ok, there are likely several places where this is happening 2008-02-08T16:05:26 you were never supposed to be calling $self->something_else on an opensrf reggisterd method 2008-02-08T16:05:35 I guess... we have a big disconnect here 2008-02-08T16:05:50 but now we're getting connected, which is good 2008-02-08T16:06:15 the first param is not $self or "this" ... 2008-02-08T16:06:37 it's "the object that the opensrf registry used to find the codref to this sub" 2008-02-08T16:06:51 wait 2008-02-08T16:06:59 now I'm confused 2008-02-08T16:07:00 ok 2008-02-08T16:07:07 step back ... 2008-02-08T16:07:23 I've conflated your $conn and my $client ... I'm sorry 2008-02-08T16:07:27 -= THIS MESSAGE NOT LOGGED =- 2008-02-08T16:07:40 so, stepping back ... 2008-02-08T16:08:19 first param: "the object that the opensrf registry used to find the codref to this sub" 2008-02-08T16:08:57 now, if there is no pig-trickery going on, like .authoritative, or ... well ... everything in the storage app ;) then you are correct 2008-02-08T16:09:12 it is an instance of __PACKAGE__ 2008-02-08T16:09:54 *whew*, ok, I feel better now 2008-02-08T16:09:57 however(!) because we can override register_method, the actual, eventual class may end up being a superclass of __PACKAGE__ 2008-02-08T16:10:18 as is the case with .authoritative, and most of storage 2008-02-08T16:10:21 and .atomic 2008-02-08T16:10:36 ok, that's pretty much spitting into the face of OO, but I can live with that 2008-02-08T16:10:45 hahaha... no, it's not! 2008-02-08T16:10:56 superclass calling a subclass method? 2008-02-08T16:11:07 s/superclass/superclass instance/ 2008-02-08T16:11:09 it's delegation 2008-02-08T16:11:19 no, it's just wrong 2008-02-08T16:11:22 haha 2008-02-08T16:11:27 ok, well, it is what it is 2008-02-08T16:11:32 yeah, i'm good with it 2008-02-08T16:11:41 i'm just glad i understand what's happening 2008-02-08T16:11:48 I appologize for the early confusion ;) 2008-02-08T16:12:22 that I caused, I mean ... I don't apologize for you being initially confused (however understandably) ;) 2008-02-08T16:12:46 right, I gotcha. I'm gonna go with the method_lookup approach.. seems safest 2008-02-08T16:13:00 well, direct call is even safer 2008-02-08T16:13:10 true 2008-02-08T16:13:20 and less code! ;) 2008-02-08T16:13:26 just use $self as a param instead of an invocant 2008-02-08T16:13:28 yes! 2008-02-08T16:13:37 a lot less, actually 2008-02-08T16:13:42 at runtime 2008-02-08T16:14:06 this feels just like PHP--I'm home! 2008-02-08T16:14:28 method_lookup is great if you know the method is in your app, but you're not sure if it's in the same package (or you're sure it's not) ... but if the sub is right next store... 2008-02-08T16:14:30 er 2008-02-08T16:14:31 * dbs imagines miker_'s guts twisting into knots 2008-02-08T16:14:32 next door 2008-02-08T16:14:41 dbs: boooo 2008-02-08T16:15:03 dbs: php learned everything it knows from perl, though, so I shouldn't be surprised by such comments ;) 2008-02-08T16:15:06 alright, one down 2008-02-08T16:15:17 berick: you want some help hunting these? 2008-02-08T16:15:42 huzzah - thanks for hashing this out on the channel - very helpful for me, too 2008-02-08T16:15:47 miker_: sure, i'm starting with circ 2008-02-08T16:16:09 dbs: heh ... teleworking helped in this case, eh? ;) 2008-02-08T16:16:59 berick: its safe to ignore WWW and Utils, I would guess? 2008-02-08T16:17:14 and SIP... 2008-02-08T16:18:09 yeah 2008-02-08T16:21:25 doing holds.pm 2008-02-08T16:21:43 oh, i'm in circ/* 2008-02-08T16:21:49 oh 2008-02-08T16:21:50 just did holds.pm 2008-02-08T16:21:51 ok 2008-02-08T16:23:42 from Open-ILS/src/perlmods/OpenILS/ : 2008-02-08T16:23:53 grep '$self->' * -r|grep -v svn|grep -v '\(WWW\|SIP\|Utils\|Reporter\|method_lookup\|api_name\|Storage\)'|cut -f1 -d:|sort|uniq -c 2008-02-08T16:24:41 berick: of course, api_name and whatnot are safe (must be called by indirection, in fact) ... just to be clear 2008-02-08T16:25:06 cool, that's what I though 2008-02-08T16:25:10 thought 2008-02-08T16:28:00 ok ... everything but circ is done, according to my grep 2008-02-08T16:28:04 I'll check that in 2008-02-08T16:28:16 yay 2008-02-08T16:28:24 what you see in circ now are non-registered method objects 2008-02-08T16:28:31 berick: there are 446 in Circulate.pm ... you want me to start on that? 2008-02-08T16:28:46 no, it's good :) 2008-02-08T16:28:52 you lost me .... 2008-02-08T16:29:28 there's one published method in Circulate.pm, and it creates a OpenILS::Application::Circ::Circulator object to handle the logic 2008-02-08T16:29:36 that object is doing all the self-> stuff 2008-02-08T16:29:42 oh 2008-02-08T16:29:46 ok, so that's fine 2008-02-08T16:30:09 similar to holdnotify 2008-02-08T16:31:05 cool, lookin' good 2008-02-08T16:31:23 tag_team++ 2008-02-08T16:31:36 @karma 2008-02-08T16:31:36 berick: Error: You need to have PySQLite installed to use Karma. Download it at 2008-02-08T16:31:57 *** sarabee has quit IRC 2008-02-08T16:35:31 *** sarabee has joined #openils-evergreen 2008-02-08T16:38:37 good night for now, folks 2008-02-08T16:38:59 later 2008-02-08T16:39:08 *** dbs has quit IRC 2008-02-08T16:39:10 indeed... latorz all 2008-02-08T17:01:17 *** Karen_ has left #OpenILS-Evergreen 2008-02-08T19:47:27 *** phase_bb has joined #openils-evergreen 2008-02-08T20:24:21 *** dbs has joined #OpenILS-Evergreen 2008-02-08T20:42:34 *** agJohn has quit IRC 2008-02-08T21:03:46 *** edc_detached has quit IRC 2008-02-08T23:03:57 *** dbs has quit IRC